From 31e1eaa6840acabc8d05242c6ffe814578a9e281 Mon Sep 17 00:00:00 2001
From: Zhang Minghan <zmh13054618081@dingtalk.com>
Date: Tue, 30 Jan 2024 21:24:05 +0800
Subject: [PATCH] fix: fix life cycle oi number-input (#62)

---
 app/src/components/ui/number-input.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/src/components/ui/number-input.tsx b/app/src/components/ui/number-input.tsx
index 748fd03..0367985 100644
--- a/app/src/components/ui/number-input.tsx
+++ b/app/src/components/ui/number-input.tsx
@@ -17,7 +17,8 @@ const NumberInput = React.forwardRef<HTMLInputElement, NumberInputProps>(
   ({ className, type, ...props }, ref) => {
     const [value, setValue] = useState(props.value.toString());
     useEffect(() => {
-      if (getValue(props.value.toString()) !== props.value) {
+      // fix life cycle: update value when props.value changed
+      if (getValue(value.toString()) !== props.value) {
         setValue(props.value.toString());
       }
     }, [props.value]);